Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FxCop and Async analyzers to the QnAMaker project. #4274

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Added FxCop and Async analyzers to the QnAMaker project. #4274

merged 1 commit into from
Jul 15, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jul 15, 2020

Relates to #2367

@gabog gabog requested a review from a team as a code owner July 15, 2020 19:37
johnataylor
johnataylor approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

libraries/Microsoft.Bot.Builder.AI.QnA/Dialogs/QnAMakerDialog.cs Show resolved Hide resolved
@gabog gabog merged commit 9343e81 into master Jul 15, 2020
@gabog gabog deleted the gabog/FxCopForQnAMaker branch July 15, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabog @johnataylor